Atom 1250 refactor#866
Merged
Merged
Conversation
added 2 commits
July 14, 2026 11:56
Drop the 8 Extent0..4 / Stride0..3 cases from the shared FlyROCDL AtomStateField enum. Their struct slots are unchanged; CopyOpGFX1250TDMType now resolves the "extent_i" / "stride_i" field names locally (tdmGeomSlot) instead of via symbolizeAtomStateField, so fly.atom.set_value still accepts them but they no longer pollute the cross-atom vocabulary. make_tdm_atom's signature/behavior and all call sites (incl. aiter) are unchanged; getConvertedType and the descriptor struct layout are identical (mask=0, extent 1..5, stride 6..9, imm_offset=10). WorkgroupMask/ImmOffset stay in the shared enum. Verified: tdm_gfx1250.mlir FileCheck + test_gfx1250_atoms.py round-trip pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist