Skip to content

Atom 1250 refactor#866

Merged
coderfeli merged 5 commits into
mainfrom
atom_1250_refactor
Jul 21, 2026
Merged

Atom 1250 refactor#866
coderfeli merged 5 commits into
mainfrom
atom_1250_refactor

Conversation

@coderfeli

Copy link
Copy Markdown
Collaborator

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

@coderfeli
coderfeli requested a review from sjfeng1999 July 16, 2026 08:14
coderfeli and others added 2 commits July 16, 2026 19:03
Drop the 8 Extent0..4 / Stride0..3 cases from the shared FlyROCDL
AtomStateField enum. Their struct slots are unchanged; CopyOpGFX1250TDMType
now resolves the "extent_i" / "stride_i" field names locally (tdmGeomSlot)
instead of via symbolizeAtomStateField, so fly.atom.set_value still accepts
them but they no longer pollute the cross-atom vocabulary.

make_tdm_atom's signature/behavior and all call sites (incl. aiter) are
unchanged; getConvertedType and the descriptor struct layout are identical
(mask=0, extent 1..5, stride 6..9, imm_offset=10). WorkgroupMask/ImmOffset
stay in the shared enum.

Verified: tdm_gfx1250.mlir FileCheck + test_gfx1250_atoms.py round-trip pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderfeli
coderfeli merged commit 5e90bf7 into main Jul 21, 2026
14 checks passed
@coderfeli
coderfeli deleted the atom_1250_refactor branch July 21, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant